Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use /etc/containers/certs.d as default option #12411

Closed
wants to merge 1 commit into from
Closed

fix: use /etc/containers/certs.d as default option #12411

wants to merge 1 commit into from

Conversation

jonyhy96
Copy link

What this PR does / why we need it:

See #10116

Which issue(s) this PR fixes:

Fixes #10116

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 25, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jonyhy96
To complete the pull request process, please assign jwhonce after the PR has been reviewed.
You can assign the PR to them by writing /assign @jwhonce in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrothberg
Copy link
Member

That is fixing a problem that does not exist. See my other comment: #10116 (comment)

I should have elaborated more. The certs dir is used but the defaults are set in containers/image, so Podman does not need to set anything.

I suggest to close this PR.

@rhatdan
Copy link
Member

rhatdan commented Nov 25, 2021

Why not change this PR to update the man pages so the man pages list this directory as default.

docs/source/markdown/podman-container-runlabel.1.md:#### --cert-dir=path
docs/source/markdown/podman-image-sign.1.md:#### --cert-dir=path
docs/source/markdown/podman-login.1.md:#### --cert-dir=path
docs/source/markdown/podman-manifest-add.1.md:#### --cert-dir=path
docs/source/markdown/podman-manifest-push.1.md:#### --cert-dir=path
docs/source/markdown/podman-pull.1.md:#### --cert-dir=path
docs/source/markdown/podman-push.1.md:#### --cert-dir=path
docs/source/markdown/podman-build.1.md:#### --cert-dir=path
docs/source/markdown/podman-play-kube.1.md:#### --cert-dir=path

@rhatdan rhatdan closed this Nov 25, 2021
@jonyhy96 jonyhy96 deleted the fix-cert-dir branch December 1, 2021 03:23
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podman pull doesn't use default --cert-dir as indicated in the manual
3 participants