Bindings test: emit GIT_COMMIT, for links in logs #12407
Conversation
Add a magic 'echo' to runner.sh, displaying $GIT_COMMIT in a special syntax. The logformatter script, seeing this, will hyperlink error messages to the failing source file. Signed-off-by: Ed Santiago <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Sorry for the Earth-killing. I would've liked to CI-colon-DOCS this, but then the new code wouldn't be exercised. |
|
LGTM |
|
LGTM |
|
/lgtm |
| # Subshell needed so logformatter will write output in cwd; if it runs in | ||
| # the subdir, .cirrus.yml will not find the html'ized log | ||
| (cd pkg/bindings/test && \ | ||
| echo "$gitcommit_magic" && \ | ||
| ginkgo -progress -trace -noColor -debug -timeout 30m -r -v) |& logformatter |
There was a problem hiding this comment.
FWIW, Cirrus-CI is able to digest jUnit format (XML) files and add direct code annotations into the PR. I think ginkgo or some other intermediate tool can produce the jUnit files, but in any case this is the point where I've always given up. Just mentioning it here in case somebody wants to give it a try.
github-actions
bot
added
the
locked - please file new issue/PR
Add a magic 'echo' to runner.sh, displaying $GIT_COMMIT in
a special syntax. The logformatter script, seeing this,
will hyperlink error messages to the failing source file.
Signed-off-by: Ed Santiago [email protected]