Rename pod on generate of container

[baude]

When generating kube of a container, the podname and container name in
the yaml are identical. This offends rules in podman where pods and
containers cannot have the same name. We now append _pod to the
podname to avoid that collision.

Signed-off-by: Brent Baude [email protected]

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [baude]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[baude]

@fatherlinux fyi ... also we should consider a backport to v3.x.

[fatherlinux]

Yeah, I'm not sure if it's worth back porting or not. I'll note for the Google searchers that find this PR/issue that you can work around this by manually creating a pod, then adding a container to it, then exporting the Kube YAML. If you just create a container, then export the Kube YAML, podman happily creates a Pod with the same name as the container which can cause this problem. It's an easy workaround, but not super intuitive to figure out how to work around.

[rhatdan]

/lgtm
/hold

[rhatdan]

Forcing Merge.