Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not store the exit command in container config #12354

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Nov 18, 2021

What this PR does / why we need it:

There is a problem with creating and storing the exit command when the
container was created. It only contains the options the container was
created with but NOT the options the container is started with. One
example would be a CNI network config. If I start a container once, then
change the cni config dir with --cni-config-dir ans start it a second
time it will start successfully. However the exit command still contains
the wrong --cni-config-dir because it was not updated.

To fix this we do not want to store the exit command at all. Instead we
create it every time the conmon process for the container is startet.
This guarantees us that the container cleanup process is startet with
the correct settings.

[NO NEW TESTS NEEDED]

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

There is a problem with creating and storing the exit command when the
container was created. It only contains the options the container was
created with but NOT the options the container is started with. One
example would be a CNI network config. If I start a container once, then
change the cni config dir with `--cni-config-dir` ans start it a second
time it will start successfully. However the exit command still contains
the wrong `--cni-config-dir` because it was not updated.

To fix this we do not want to store the exit command at all. Instead we
create it every time the conmon process for the container is startet.
This guarantees us that the container cleanup process is startet with
the correct settings.

[NO NEW TESTS NEEDED]

Signed-off-by: Paul Holzinger <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2021
@Luap99
Copy link
Member Author

Luap99 commented Nov 18, 2021

@mheon PTAL

@mheon
Copy link
Member

mheon commented Nov 18, 2021

I'm now realizing that a large part of the original decision-making around Specgen was to keep Podman and Libpod unentangled, so Libpod could be used outside of podman (the new implementation enforces Podman-style CLI for the exit command). I don't think we care about this as much now, though.

Code LGTM.

@Luap99
Copy link
Member Author

Luap99 commented Nov 18, 2021

I'm now realizing that a large part of the original decision-making around Specgen was to keep Podman and Libpod unentangled, so Libpod could be used outside of podman (the new implementation enforces Podman-style CLI for the exit command). I don't think we care about this as much now, though.

That makes sense, thanks.

@rhatdan
Copy link
Member

rhatdan commented Nov 18, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2021
@openshift-merge-robot openshift-merge-robot merged commit 319d3fb into containers:main Nov 18, 2021
@Luap99 Luap99 deleted the exit-command branch November 19, 2021 08:50
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants