Restore runtime verification #12351
Merged
Restore runtime verification #12351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes LGTM, but one or more of the files need some gofmt help @adrianreber |
|
Probably need to rebase as well. CI has been sick today. |
adrianreber
force-pushed
the
2021-11-18-restore-runtime-verification
branch
from
e2ac6a0 to
9d517da
Compare
|
gofmt fixed and rebased |
adrianreber
force-pushed
the
2021-11-18-restore-runtime-verification
branch
from
9d517da to
c188b30
Compare
|
Tests not happy. |
|
Seems like I broke checkpointing. Looking into it. |
rst0git
reviewed
Nov 19, 2021
adrianreber
force-pushed
the
2021-11-18-restore-runtime-verification
branch
from
c188b30 to
492a584
Compare
There are at least two runtimes that support checkpoint and restore: runc and crun. Although the checkpoints created by these are almost compatible, it is not (yet) possible to restore a checkpoint created with one runtime with the other runtime. To make checkpoint/restore usage more comfortable this adds code to look into the checkpoint archive during restore and to set the runtime to the one used during checkpointing. This also adds a check, if the user explicitly sets a runtime during restore, that the runtime is also the same as used during checkpointing. If a different runtime is selected than the one used during checkpointing the restore will fail early. If runc and crun will create compatible checkpoints in the future the check can be changed to treat crun and runc as compatible checkpoint/restore runtimes. Signed-off-by: Adrian Reber <[email protected]>
On container restore ensures that the same container runtime is used as during checkpointing and it also ensures that the user does not select a different runtime. Signed-off-by: Adrian Reber <[email protected]>
adrianreber
force-pushed
the
2021-11-18-restore-runtime-verification
branch
from
492a584 to
ced0ffb
Compare
vrothberg
reviewed
Nov 22, 2021
flouthoc
approved these changes
Nov 22, 2021
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianreber, flouthoc, mheon, rst0git The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are at least two runtimes that support checkpoint and restore: runc and crun. Although the checkpoints created by these are almost compatible, it is not (yet) possible to restore a checkpoint created with one runtime with the other runtime. To make checkpoint/restore usage more comfortable this adds code to look into the checkpoint archive during restore and to set the runtime to the one used during checkpointing.
This also adds a check, if the user explicitly sets a runtime during restore, that the runtime is also the same as used during checkpointing.
If a different runtime is selected than the one used during checkpointing the restore will fail early.
If runc and crun will create compatible checkpoints in the future the check can be changed to treat crun and runc as compatible checkpoint/restore runtimes.
Fixes: #11945