fix CI #12343
fix CI #12343
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@edsantiago @cevich PTAL |
|
Failure looks real: |
test/e2e/run_test.go
Outdated
| @@ -1515,8 +1515,8 @@ USER mail`, BB) | |||
| Expect(session.ErrorToString()).To(ContainSubstring("file descriptor 3 is not available")) | |||
| }) | |||
|
|
|||
| It("podman run --privileged and --group-add", func() { | |||
| groupName := "kvm" | |||
| FIt("podman run --privileged and --group-add", func() { | |||
There was a problem hiding this comment.
Thank you for catching this!
|
LGTM for reference |
Our fedora-minimal image on Quay bases on fedora-minimal:latest which starting with F35 removed a number of binaries that our CI depends on. Fix that by pulling `fedora-minimal:34` from the Fedora registry directly. Once the build bot on Quay has been disabled, we move the image over there to make sure that it will not change over time. Signed-off-by: Valentin Rothberg <[email protected]>
Q: We own the Dockerfile that makes this image, why not simply add a |
I find it wasteful to rebuild an image (that never changes) after each PR. |
|
I have super-strong opinions about test images: they should not change. Ever. For discussion (later): I recommend using my system-test convention. Not foo:latest, but foo:YYYYMMDD. |
I agree with this also. I was just saying, to get things working we can make the image however we want for now. The auto-build trigger has been disabled. |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
Flake is the usual registry.redhat.io one. Restarted. |
Thank you! |
|
IRC Discussion summary:
|
|
Thank you, @cevich ! |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
🕺 thanks everybody! |
Around 18th of Nov. 2021, a new/incompatible `quay.io/libpod/fedora-minimal:latest` was pushed by the quay auto-builder servicing the podman repo. This caused a number of problems across several branches. To address this, the auto-builder was disabled and a fixed F34 based image was tagged and pushed as both `latest` and `34`. However, all repositories which use this test image need to be individually updated to reference it. See containers/podman#12343 Signed-off-by: Chris Evich <[email protected]>
[Backport containers#12343, which fixes the change in fedora-minimal image] Our fedora-minimal image on Quay bases on fedora-minimal:latest which starting with F35 removed a number of binaries that our CI depends on. Fix that by pulling `fedora-minimal:34` from the Fedora registry directly. Once the build bot on Quay has been disabled, we move the image over there to make sure that it will not change over time. Signed-off-by: Valentin Rothberg <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Our fedora-minimal image on Quay bases on fedora-minimal:latest which
starting with F35 removed a number of binaries that our CI depends on.
Fix that by pulling
fedora-minimal:34from the Fedora registrydirectly.
Once the build bot on Quay has been disabled, we move the image over
there to make sure that it will not change over time.
Signed-off-by: Valentin Rothberg [email protected]