-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: take absolute path for dd on apple silicon #12330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
@baude PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our CI enforces to add/edit tests but podman machine
isn't exercised there yet. In order to pass the checks, could you add '[NO NEW TESTS NEEDED]'
to your commit message and repush?
Fixes containers#12329 [NO NEW TESTS NEEDED] podman machine Signed-off-by: Michael Rödel <[email protected]>
All green! Do you need a additional PR for 3.4? |
Are we even doing a fresh release off the v3.4 branch at this point? I don't know if we are |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: etenzy, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Change the path for dd to absolute if dd has been overwritten (e.g. by coreutils)
How to verify it
On Apple silicon
Which issue(s) this PR fixes:
Fixes #12329