Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: take absolute path for dd on apple silicon #12330

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

etenzy
Copy link
Contributor

@etenzy etenzy commented Nov 17, 2021

What this PR does / why we need it:

Change the path for dd to absolute if dd has been overwritten (e.g. by coreutils)

How to verify it

On Apple silicon

brew install coreutils
podman machine init

Which issue(s) this PR fixes:

Fixes #12329

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@baude PTAL

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our CI enforces to add/edit tests but podman machine isn't exercised there yet. In order to pass the checks, could you add '[NO NEW TESTS NEEDED]' to your commit message and repush?

Fixes containers#12329

[NO NEW TESTS NEEDED] podman machine

Signed-off-by: Michael Rödel <[email protected]>
@etenzy
Copy link
Contributor Author

etenzy commented Nov 17, 2021

All green!

Do you need a additional PR for 3.4?

@TomSweeneyRedHat
Copy link
Member

LGTM @acui @bbaude @jwhonce PTAL
@mheon, thoughts on the backport?

@mheon
Copy link
Member

mheon commented Nov 17, 2021

Are we even doing a fresh release off the v3.4 branch at this point? I don't know if we are

@rhatdan
Copy link
Member

rhatdan commented Nov 18, 2021

/approve
/lgtm
@mheon I think we should do a podman 3.5 purely to get new features/fixes for podman on MAC. Particularly to get dial-stdio.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: etenzy, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2021
@openshift-merge-robot openshift-merge-robot merged commit 69e1204 into containers:main Nov 18, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compatibility with coreutils on apple silicon
6 participants