rootless: use catatonit to maintain user+mnt namespace #12326
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@vrothberg PTAL |
| @@ -106,6 +106,10 @@ do_pause () | |||
| for (i = 0; sig[i]; i++) | |||
| sigaction (sig[i], &act, NULL); | |||
|
|
|||
| /* Attempt to execv catatonit to keep the pause process alive. */ | |||
| execl ("/usr/libexec/podman/catatonit", "catatonit", "-P", NULL); | |||
There was a problem hiding this comment.
Some distributions (e.g., openSUSE) ship it in /usr/bin/catatonit. Could we add another fallback for that?
There was a problem hiding this comment.
is it fine to assume it has support for -P even when distributed under /usr/bin?
There was a problem hiding this comment.
amended and pushed a new version
There was a problem hiding this comment.
is it fine to assume it has support for
-Peven when distributed under/usr/bin?
I think so since Podman now requires catatonit >= 0.17.0
|
LGTM, other then the path. |
if catatonit is present, use it to keep the rootless user+mnt namespace alive. [NO NEW TESTS NEEDED] no new features added. Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
catatonit-rootless
branch
from
214f5ad to
3073543
Compare
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
LGTM |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
if catatonit is present, use it to keep the rootless user+mnt
namespace alive.
[NO NEW TESTS NEEDED] no new features added.
Signed-off-by: Giuseppe Scrivano [email protected]