hack/bats: deal with new bin helpers

[edsantiago]

Some time in the last month, podman started to depend on a bunch
of external helper binaries: rootlessport, pause, catatonit.
System tests fail without these.

Update the hack/bats script to pass $CONTAINERS_HELPER_BINARIES_DIR
(set to ./bin); podman will then use locally-built helpers. (This
requires containers/common#823 , which as
of this PR is not yet vendored into podman. There is no harm in
merging this while we wait.)

Also: if bats helper is invoked as root, run only once; i.e.,
skip the "rootless" step.

Also (piggybacked): the name of the podman pause image has
changed, from pause to podman-pause. Adjust that in our
teardown so we don't leave droppings.

Signed-off-by: Ed Santiago [email protected]

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [edsantiago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[edsantiago]

Example log showing the problem addressed by the podman-pause portion of this PR. (The ugly red 'stray' lines at bottom).

[rhatdan]

LGTM if tests pass.

[edsantiago]

(hack/bats is used only on developer workstations, never in CI. CI will almost certainly fail, due to the current set of flakes, but not because of anything in this PR)

[TomSweeneyRedHat]

LGTM
@edsantiago did you add a new tag "CI will almost certainly fail", to ensure only your PR won't flake? ;^)

[TomSweeneyRedHat]

/lgtm