rename libpod nettypes fields #12319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some field names are confusing. Change them so that they make more sense to the reader. Since these fields are only in the main branch we can safely rename them without worrying about backwards compatibility. Note we have to change the field names in netavark too. Signed-off-by: Paul Holzinger <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Luap99
added a commit
to Luap99/netavark
that referenced
this pull request
Nov 16, 2021
Some field names are confusing. Change them so that they make more sense to the reader. I also added copmment to the types to provide more context. also see containers/podman#12319 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
added a commit
to Luap99/netavark
that referenced
this pull request
Nov 16, 2021
Some field names are confusing. Change them so that they make more sense to the reader. I also added comments to the types to provide more context. also see containers/podman#12319 Signed-off-by: Paul Holzinger <[email protected]>
|
netavark PR: containers/netavark#79 |
|
LGTM |
|
LGTM |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Some field names are confusing. Change them so that they make more sense
to the reader.
Since these fields are only in the main branch we can safly rename them
without worrying about backwards compatibility.
Note we have to change the field names in netavark too.
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer: