Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

play kube: don't force-pull infra image #12280

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

vrothberg
Copy link
Member

Do not force-pull the infra image in play kube but let the backend
take care of that when creating the pod(s) which may build a local
podman-pause image instead of using the default infra image.

Fixes: #12254
Signed-off-by: Valentin Rothberg [email protected]

Do not force-pull the infra image in `play kube` but let the backend
take care of that when creating the pod(s) which may build a local
`podman-pause` image instead of using the default infra image.

Fixes: containers#12254
Signed-off-by: Valentin Rothberg <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2021
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Nov 12, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2021
@openshift-merge-robot openshift-merge-robot merged commit 19c79ee into containers:main Nov 12, 2021
@setharnold
Copy link

Hello, was a CVE assigned for this issue? Thanks

@vrothberg vrothberg deleted the fix-12254 branch February 23, 2023 07:27
@vrothberg
Copy link
Member Author

vrothberg commented Feb 23, 2023

Hello, was a CVE assigned for this issue? Thanks

No. Can you elaborate on why you think it's CVE worthy?

@setharnold
Copy link

Thanks @vrothberg -- some of our users have been asking for this and it felt pretty innocuous to me. I was curious if I overlooked something that would be documented elsewhere, etc.

@vrothberg
Copy link
Member Author

Thanks! I agree that it's a rather harmless issue and more a feature than a bug fix.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

play kube: brings in unwanted k8s pause
5 participants