-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
play kube: don't force-pull infra image #12280
Conversation
Do not force-pull the infra image in `play kube` but let the backend take care of that when creating the pod(s) which may build a local `podman-pause` image instead of using the default infra image. Fixes: containers#12254 Signed-off-by: Valentin Rothberg <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/lgtm |
Hello, was a CVE assigned for this issue? Thanks |
No. Can you elaborate on why you think it's CVE worthy? |
Thanks @vrothberg -- some of our users have been asking for this and it felt pretty innocuous to me. I was curious if I overlooked something that would be documented elsewhere, etc. |
Thanks! I agree that it's a rather harmless issue and more a feature than a bug fix. |
Do not force-pull the infra image in
play kube
but let the backendtake care of that when creating the pod(s) which may build a local
podman-pause
image instead of using the default infra image.Fixes: #12254
Signed-off-by: Valentin Rothberg [email protected]