Always create working directory when using compat API #12279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker/Moby always create the working directory, and some tools rely on that behavior (example, woodpecker/drone). Fixes containers#11842 Signed-off-by: Michael Scherer <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mscherer, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker/Moby always create the working directory, and some tools
rely on that behavior (example, woodpecker/drone).
Fixes #11842
What this PR does / why we need it:
Because it fix a bug that made me very sad, as I would not be able to use podman instead of docker.
How to verify it
The original bug report has the API calls that trigger the bug.
Or it can be verified by deploying woodpecker with podman serving as the backend, and try to trigger a CI job.
(I have such setup, and verified the patch).
To trigger, you have to start a container with a named volume, and the workind directory being a subdir on that volume. Eg, having workdir set to /scratch/project, and /scratch being a volume created before.
Which issue(s) this PR fixes:
Fixes #11842
Special notes for your reviewer: