Bump to v3.4.2

[mheon]

As the title says

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mheon]

Lot of small changes this time around - lot of commits but most are docs.

[rhatdan]

LGTM
If it passes tests.

[TomSweeneyRedHat]

@mheon, couple red tests

[TomSweeneyRedHat]

Suggested change

	- Fixed a bug where volume mounts from `podman play kube` created with a trailing `/` in the container path were were not properly superseding named volumes from the image ([#9618](https://github.com/containers/podman/issues/9618)).
	- Fixed a bug where volume mounts from `podman play kube` created with a trailing `/` in the container path were were not properly superseding named volumes from the image ([#9618](https://github.com/containers/podman/issues/9618)).

[rhatdan]

The above fix has a "were were" in it.

[mheon]

These are old release notes, so I don't want to change them beyond spelling fixes

[rhatdan]

Sure, get the tests to pass and we can merge.

[TomSweeneyRedHat]

Thanks on the were were @rhatdan, thought I'd killed one in my comment.

[TomSweeneyRedHat]

one nit and a whole lot of red unhappiness in the tests

[Luap99]

I think you have to drop 605c9e77289e2010c027758d003f101f12785584. The journald test will not pass without the required journald fixes which are only in the main branch because of breaking changes to the log endpoint.

[mheon]

We have a request to get that fix landed, so that could be problematic.

[Luap99]

I am able to get the test working with this diff:

diff --git a/libpod/container_log_linux.go b/libpod/container_log_linux.go
index 4029d0af7..b6b780bab 100644
--- a/libpod/container_log_linux.go
+++ b/libpod/container_log_linux.go
@@ -140,6 +140,7 @@ func (c *Container) readFromJournal(ctx context.Context, options *logs.LogOption
                        doTail = false
                }
                lastReadCursor := ""
+               partial := ""
                for {
                        select {
                        case <-ctx.Done():
@@ -229,6 +230,12 @@ func (c *Container) readFromJournal(ctx context.Context, options *logs.LogOption
                                logrus.Errorf("Failed parse log line: %v", err)
                                return
                        }
+                       if logLine.Partial() {
+                               partial += logLine.Msg
+                               continue
+                       }
+                       logLine.Msg = partial + logLine.Msg
+                       partial = ""
                        if doTail {
                                tailQueue = append(tailQueue, logLine)
                                continue

This is not a breaking change, it just combines the partial lines into one single line like it is done for the file backend:

podman/libpod/container_log.go

Lines 91 to 97 in 92da868

	if nll.Partial() {
	partial += nll.Msg
	continue
	} else if !nll.Partial() && len(partial) > 0 {
	nll.Msg = partial + nll.Msg
	partial = ""
	}

[mheon]

Force-pushed with fix - thanks bunches @Luap99

[mheon]

Looks good, integration tests are all passing.

[mheon]

System tests are failing, unrelated to earlier failures. I think I might have grabbed a patch from Ed that depends on functionality in system connection ls that isn't in this branch.

[mheon]

Pulled the patch out, repushed

[rhatdan]

/lgtm