network reload without ports should not reload ports

[Luap99]

What this PR does / why we need it:

When run as rootless the podman network reload command tries to reload
the rootlessport ports because the childIP could have changed.
However if the containers has no ports we should skip this instead of
printing a warning.

network reload return error if we cannot reload ports

As rootless we have to reload the port mappings. If it fails we should
return an error instead of the warning.

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mheon]

Code LGTM, tests are red

[Luap99]

Looks like a registry failure only the podman search tests are failing.

[rhatdan]

@Luap99 sorry rebase required
LGTM

[Luap99]

Tests are green, please merge

[Luap99]

/hold

[Luap99]

/hold cancel This should be good now, thanks @edsantiago

[edsantiago]

All three additions are NOPs. Also, even when I fix them on my end, I still can't get the test to fail using podman @ main.

[Luap99]

The changed e2e test should fail on main.

[edsantiago]

Solved it! Could I make a friendly suggestion?

diff --git a/test/system/500-networking.bats b/test/system/500-networking.bats
index 4d1d88aba..21350ed36 100644
--- a/test/system/500-networking.bats
+++ b/test/system/500-networking.bats
@@ -456,6 +456,12 @@ load helpers
         die "MAC address did not change after podman network disconnect/connect"
     fi

+    # Disconnect/reconnect of a container *with no ports* should succeed quietly
+    run_podman network disconnect $netname $background_cid
+    is "$output" "" "disconnect of container with no open ports"
+    run_podman network connect $netname $background_cid
+    is "$output" "" "(re)connect of container with no open ports"
+
     # FIXME FIXME FIXME: #11825: bodhi tests are failing, remote+rootless only,
     # with "dnsmasq: failed to create inotify". This error has never occurred
     # in CI, and Ed has been unable to reproduce it on 1minutetip. This next

With the above addition, the test fails on main and passes on your PR.

[Luap99]

@edsantiago added your diff, thanks

[rhatdan]

/lgtm
/hold cancel