pod create: read network mode from config #12222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
LGTM |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/lgtm |
|
Tests are very unhappy. |
Luap99
force-pushed
the
pod-create-net
branch
from
2b3cc51 to
760bb78
Compare
|
/lgtm |
Luap99
force-pushed
the
pod-create-net
branch
from
760bb78 to
9c23225
Compare
When we create a pod we have to parse the network mode form the config file. This is a regression in commit d28e857. Fixes containers#12207 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
force-pushed
the
pod-create-net
branch
from
9c23225 to
8b7b0b7
Compare
|
LGTM |
|
/lgtm |
openshift-ci
bot
added
lgtm
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When we create a pod we have to parse the network mode form the config
file. This is a regression in commit d28e857.
How to verify it
Which issue(s) this PR fixes:
Fixes #12207
Special notes for your reviewer: