test/system: podman run update /etc/hosts #12219
Conversation
This test case is used for covering rhbz#1902979. Signed-off-by: Alex Jia <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chuanchang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@edsantiago PTAL |
There was a problem hiding this comment.
Thank you for your PRs!
A few fixes needed. And, in this and all your other PRs, could you resubmit with a more descriptive commit message? A commit message should be something that a future maintainer can read without reference to other sources. It's OK to link to external BZs or issues, but please give a short description of what the problem actually is. (This is especially important with BZs that have a lot of RH-internal-only comments).
| @@ -736,4 +736,11 @@ EOF | |||
| is "$output" "$random_1" "output matches STDIN" | |||
| } | |||
|
|
|||
| # rhbz#1902979 : podman run fails to update /etc/hosts when --uidmap is provided | |||
| @test "podman run update /etc/hosts" { | |||
| HOSTS=$(random_string 25) | |||
There was a problem hiding this comment.
Suggestion: use singular (HOST), not plural. Plural is confusing here.
| @test "podman run update /etc/hosts" { | ||
| HOSTS=$(random_string 25) | ||
| run_podman run --uidmap 0:10001:10002 --rm --hostname $HOSTS $IMAGE grep $HOSTS /etc/hosts | ||
| is "${lines[0]}" ".*$HOSTS.*" |
There was a problem hiding this comment.
This check is unnecessary: if the grep above were to fail, run_podman would issue a failure.
test/system/030-run.bats
Outdated
| @@ -736,4 +736,11 @@ EOF | |||
| is "$output" "$random_1" "output matches STDIN" | |||
| } | |||
|
|
|||
| # rhbz#1902979 : podman run fails to update /etc/hosts when --uidmap is provided | |||
| @test "podman run update /etc/hosts" { | |||
There was a problem hiding this comment.
Please make this test name more descriptive, such as by including something about uidmap.
openshift-ci
bot
added
the
needs-rebase
|
@chuanchang please rebase |
openshift-ci
bot
removed
the
needs-rebase
|
A friendly reminder that this PR had no activity for 30 days. |
github-actions
bot
added
the
locked - please file new issue/PR
This test case is used for covering rhbz#1902979.
Signed-off-by: Alex Jia [email protected]
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer: