Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bindings container log test #12177

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Nov 4, 2021

What this PR does / why we need it:

The returned error was not checked, thus the test could hang forever
since it blocks on the log channel.

How to verify it

Which issue(s) this PR fixes:

Fixes #12176

Special notes for your reviewer:

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2021
The returned error was not checked, thus the test could hang forever
since it blocks on the log channel.

Also handle unexpectedEOF like EOF.

Fixes containers#12176

Signed-off-by: Paul Holzinger <[email protected]>
@edsantiago
Copy link
Member

Tested on f35, works very nicely:

# ginkgo -trace -debug -r -v -focus logging
...
• Failure [3.653 seconds]
Podman containers
/root/podman/pkg/bindings/test/containers_test.go:18
  logging [It]
  /root/podman/pkg/bindings/test/containers_test.go:356

  Unexpected error:
      <*errors.withStack | 0xc0004ba960>: {
          error: <*errors.withMessage | 0xc0004ee340>{
              cause: <*errors.fundamental | 0xc0000f6048>{
                  msg: "lost synchronization with multiplexed stream",
                  stack: [0xefc569, 0x4534cc, 0x453452, 0x453452, 0x4456c5, 0x47d1e1],
              },
              msg: "channel \"123\" found, 0-3 supported",
          },
          stack: [0xef4025, 0xef902f, 0xf975de, 0x47d1e1],
      }
      channel "123" found, 0-3 supported: lost synchronization with multiplexed stream
  occurred

  /root/podman/pkg/bindings/test/containers_test.go:374
...

@mheon
Copy link
Member

mheon commented Nov 4, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2021
@openshift-merge-robot openshift-merge-robot merged commit 28bbd14 into containers:main Nov 4, 2021
@Luap99 Luap99 deleted the log-test branch November 4, 2021 17:44
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bindings tests: need better error detection
4 participants