-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement top streaming for containers and pods #12159
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jwhonce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d34b97d
to
97795ff
Compare
* Implement API query parameter stream and delay for containers and pods top endpoints * Update swagger with breaking changes * Add python API tests for endpoints Fixes containers#12115 Signed-off-by: Jhon Honce <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think this should also be added to the CLI. |
@containers/podman-maintainers PTAL |
CLI already has this feature, and it was initially a breaking change until I changed the documentation. I'll remove the flag. |
/lgtm |
|
Concur with @Luap99 - there is no streaming built into the current CLI implementation. Do we need a card to add that? It seems like a reasonable ask. |
pods top endpoints
Fixes #12115
Signed-off-by: Jhon Honce [email protected]
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer: