Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement top streaming for containers and pods #12159

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented Nov 1, 2021

  • Implement API query parameter stream and delay for containers and
    pods top endpoints
  • Update swagger with breaking changes
  • Add python API tests for endpoints

Fixes #12115

Signed-off-by: Jhon Honce [email protected]

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

@jwhonce jwhonce added kind/bug Categorizes issue or PR as related to a bug. HTTP API Bug is in RESTful API breaking-change A change that will require a full version bump, i.e. 3.* to 4.* labels Nov 1, 2021
@jwhonce jwhonce requested review from baude and vrothberg November 1, 2021 21:20
@jwhonce jwhonce self-assigned this Nov 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2021
@jwhonce jwhonce force-pushed the issues/12115 branch 2 times, most recently from d34b97d to 97795ff Compare November 1, 2021 22:31
* Implement API query parameter stream and delay for containers and
  pods top endpoints
* Update swagger with breaking changes
* Add python API tests for endpoints

Fixes containers#12115

Signed-off-by: Jhon Honce <[email protected]>
Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luap99
Copy link
Member

Luap99 commented Nov 2, 2021

I think this should also be added to the CLI.
Also why is this marked as breaking change you only add new options, no?

@jwhonce
Copy link
Member Author

jwhonce commented Nov 2, 2021

@containers/podman-maintainers PTAL

@jwhonce
Copy link
Member Author

jwhonce commented Nov 2, 2021

I think this should also be added to the CLI. Also why is this marked as breaking change you only add new options, no?

CLI already has this feature, and it was initially a breaking change until I changed the documentation. I'll remove the flag.

@jwhonce jwhonce removed the breaking-change A change that will require a full version bump, i.e. 3.* to 4.* label Nov 2, 2021
@rhatdan
Copy link
Member

rhatdan commented Nov 2, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2021
@openshift-merge-robot openshift-merge-robot merged commit 33643f4 into containers:main Nov 2, 2021
@Luap99
Copy link
Member

Luap99 commented Nov 2, 2021

I think this should also be added to the CLI. Also why is this marked as breaking change you only add new options, no?

CLI already has this feature, and it was initially a breaking change until I changed the documentation. I'll remove the flag.

podman top prints once for me and I do not see a streaming option

@mheon
Copy link
Member

mheon commented Nov 4, 2021

Concur with @Luap99 - there is no streaming built into the current CLI implementation. Do we need a card to add that? It seems like a reasonable ask.

@jwhonce
Copy link
Member Author

jwhonce commented Nov 17, 2021

@Luap99 Sorry for the confusion, I must have been thinking of some other command. I agree streaming is good for the CLI as well.

@mheon Either a card or GH issue would be good.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. HTTP API Bug is in RESTful API kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: list processes for pods and containers doesn't stream
6 participants