Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stop message more similar to start #12157

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

afbjorklund
Copy link
Contributor

@afbjorklund afbjorklund commented Nov 1, 2021

[NO NEW TESTS NEEDED]

The current message from "stop" is printed from the wrong place (library function, instead of command)

And it is also missing a newline, and having a slightly different syntax than the "start" output earlier.

BEFORE

$ podman machine stop
Successfully stopped machine: podman-machine-default$ 

AFTER

$ ./bin/podman machine stop
Machine "podman-machine-default" stopped successfully
$

@jwhonce
Copy link
Member

jwhonce commented Nov 1, 2021

LGTM

@rhatdan
Copy link
Member

rhatdan commented Nov 2, 2021

Either add a test or add [NO NEW TEST NEEDED]

@rhatdan
Copy link
Member

rhatdan commented Nov 2, 2021

LGTM

[NO TESTS NEEDED]

Signed-off-by: Anders F Björklund <[email protected]>
@TomSweeneyRedHat
Copy link
Member

LGTM
I've restarted the "fedora-33 rootless host" test, it looked to be having network issues.

@rhatdan
Copy link
Member

rhatdan commented Nov 3, 2021

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 3, 2021
@openshift-merge-robot openshift-merge-robot merged commit a245da1 into containers:main Nov 3, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants