Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix help message case for podman version #12141

Merged
merged 1 commit into from
Oct 30, 2021

Conversation

kprav33n
Copy link
Contributor

What this PR does / why we need it:

This is a cosmetic change. The help message for podman version is in
title case whereas all other command help messages are not in title
case. This stands out as inconsistent when looking at the output of
podman help.

This PR fixes the case for the help message for the version subcommand.

How to verify it

Run podman help and look at the help string for the version subcommand.

Before

podman help | grep version
  version     Display the Podman Version Information

After

podman help | grep version
  version     Display the Podman version information

Special notes for your reviewer:

Just for comparison, I double checked the help message for the version subcommand in docker.

$ docker help | grep version
  -v, --version            Print version information and quit
  version     Show the Docker version information

@TomSweeneyRedHat
Copy link
Member

Nice eagle eye and fix @kprav33n ! TYVM
LGTM

@kprav33n
Copy link
Contributor Author

kprav33n commented Oct 29, 2021

Thank you! I'm working on adding a corresponding test to go with it. Or, should I add [NO NEW TESTS NEEDED] in the commit body? Let me resubmit shortly.

This is a cosmetic change. The help message for `podman version` is in
title case whereas all other command help messages are not in title
case. This stands out as inconsistent when looking at the output of
`podman help`.

Signed-off-by: Praveen Kumar <[email protected]>
@kprav33n
Copy link
Contributor Author

/test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2021

@kprav33n: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mheon
Copy link
Member

mheon commented Oct 29, 2021

Test failure looks like a flake

@rhatdan
Copy link
Member

rhatdan commented Oct 30, 2021

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kprav33n, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2021
@openshift-merge-robot openshift-merge-robot merged commit 7cd317e into containers:main Oct 30, 2021
@kprav33n kprav33n deleted the help-doc branch October 30, 2021 21:39
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants