Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cirrus: Authorize rootless user self-ssh #12139

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

cevich
Copy link
Member

@cevich cevich commented Oct 29, 2021

What this PR does / why we need it:

Future testing needs dictate rootless (in addition to root) users are
able to ssh to localhost. Add ssh-key generation commands for the
rootless user, and authorize their public key.

Minor: Also remove update of /etc/sub{uid,gid} files, since this is
now done automatically by {user,group}add commands.

How to verify it

All "rootless" tests will pass.

Which issue(s) this PR fixes:

Supports #12036

Special notes for your reviewer:

@cevich cevich requested a review from jwhonce October 29, 2021 15:19
@cevich cevich force-pushed the add_rootless_sshkey branch 4 times, most recently from 039f5d9 to df67e88 Compare November 1, 2021 14:09
Future testing needs dictate rootless (in addition to root) users are
able to ssh to localhost.  Add ssh-key generation commands for the
rootless user, and authorize their public key.

Minor: Also remove update of `/etc/sub{uid,gid}` files, since this is
now done automatically by `{user,group}add` commands.

Signed-off-by: Chris Evich <[email protected]>
@cevich cevich force-pushed the add_rootless_sshkey branch from df67e88 to 9c34bd5 Compare November 1, 2021 16:05
@cevich
Copy link
Member Author

cevich commented Nov 1, 2021

@jwhonce there we go, all green (finally). Sorry that took a while, my head has been quite foggy recently.

@jwhonce
Copy link
Member

jwhonce commented Nov 1, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2021
@jwhonce
Copy link
Member

jwhonce commented Nov 1, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2021
@openshift-merge-robot openshift-merge-robot merged commit 3147ff8 into containers:main Nov 1, 2021
@cevich cevich deleted the add_rootless_sshkey branch April 18, 2023 14:50
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants