Error logs --follow if events-backend != journald, event-logger=journald #12130
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
libpod/container_log_linux.go
Outdated
| @@ -44,6 +44,9 @@ func (c *Container) initializeJournal(ctx context.Context) error { | |||
| } | |||
|
|
|||
| func (c *Container) readFromJournal(ctx context.Context, options *logs.LogOptions, logChannel chan *logs.LogLine) error { | |||
| if options.Follow && c.runtime.EventerType() != "journald" { | |||
There was a problem hiding this comment.
There is already a check for that below in line 110 which is probably not doing the right thing. Can you update that instead or move it back up here?
There was a problem hiding this comment.
Moved that check up to here.
|
One thing that troubles me greatly about this is that $ bin/podman --events-backend=file run -d --rm --log-driver=journald --name foo $iii sh -c 'echo hi;sleep 30;echo bye'
98c795d4eae3d65e8537d16a179fcf13d25bd1ab3a85b2720440264f5b8560f8
$ bin/podman logs -f foo | ts
Oct 28 08:32:24 hi
Oct 28 08:32:51 bye <--- hangs after this point. |
|
It does this because you could restart the container, but since the container was removed, podman logs should probably realize that and exit. with a Warning. |
|
It should just exit. |
|
The logs error is not going to be fixed in the issue. |
|
Changes LGTM |
Fixes: containers#11255 Signed-off-by: Daniel J Walsh <[email protected]>
|
LGTM |
github-actions
bot
added
the
locked - please file new issue/PR
Fixes: #11255
Signed-off-by: Daniel J Walsh [email protected]
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer: