-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily disable cgroups=disabled test #12121
Conversation
Ref: containers#11191 Signed-off-by: Chris Evich <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cevich The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Correct, he will need to revert this commit in his PR. My intention with this PR is to decouple the (eventual) fix from merge of #11795 since they're of different purpose - no need to rush a fix just to get new VM images in (or the other way around). |
Clarification: I'm okay if we decide to just close this PR. I can simply smash the re-run button in #11795 should this error come up again. |
I'd vote to see if @giuseppe 's PR catches the little booger and I'd put this one on hold for now. |
if you don't mind let's give my PR a try and see if we catch again the same failure or if it is a different error |
Nope, I don't mind at all. This is just a decoupling option in case we need it - I've been working on that damn F35b PR for a month now, so I'm eager to be done with it 😖 But if you can find/fix faster, that's even better. |
Forgot this is a somewhat-rare flake, closing this so we can wait and see if this pops up again. |
What this PR does / why we need it:
Temporarily disable test so deeper debugging can be performed (i.e. via #12120)
Issue ref: #11191
How to verify it
Very difficult / impossible since it's a fairly rare race. Test will be re-enabled once actual problem is discovered.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None