Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable cgroups=disabled test #12121

Closed
wants to merge 1 commit into from

Conversation

cevich
Copy link
Member

@cevich cevich commented Oct 27, 2021

What this PR does / why we need it:

Temporarily disable test so deeper debugging can be performed (i.e. via #12120)

Issue ref: #11191

How to verify it

Very difficult / impossible since it's a fairly rare race. Test will be re-enabled once actual problem is discovered.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cevich
To complete the pull request process, please assign edsantiago after the PR has been reviewed.
You can assign the PR to them by writing /assign @edsantiago in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@edsantiago
Copy link
Member

Um, if you disable the test, then @giuseppe's debugging check #12120 will never trigger?

@cevich
Copy link
Member Author

cevich commented Oct 27, 2021

Um, if you disable the test, then @giuseppe's debugging check #12120 will never trigger?

Correct, he will need to revert this commit in his PR. My intention with this PR is to decouple the (eventual) fix from merge of #11795 since they're of different purpose - no need to rush a fix just to get new VM images in (or the other way around).

@cevich
Copy link
Member Author

cevich commented Oct 27, 2021

Clarification: I'm okay if we decide to just close this PR. I can simply smash the re-run button in #11795 should this error come up again.

@TomSweeneyRedHat
Copy link
Member

I'd vote to see if @giuseppe 's PR catches the little booger and I'd put this one on hold for now.

@giuseppe
Copy link
Member

if you don't mind let's give my PR a try and see if we catch again the same failure or if it is a different error

@cevich
Copy link
Member Author

cevich commented Oct 28, 2021

Nope, I don't mind at all. This is just a decoupling option in case we need it - I've been working on that damn F35b PR for a month now, so I'm eager to be done with it 😖 But if you can find/fix faster, that's even better.

@cevich
Copy link
Member Author

cevich commented Nov 1, 2021

Forgot this is a somewhat-rare flake, closing this so we can wait and see if this pops up again.

@cevich cevich closed this Nov 1, 2021
@cevich cevich deleted the skip_cgroups_disabled branch April 18, 2023 14:49
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants