Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Add information on how podman machine is updated #12119

Merged
merged 1 commit into from
Oct 30, 2021

Conversation

ashley-cui
Copy link
Member

Update documentation on how the default podman machine distribution,
FCOS, is updated.

[CI:DOCS]

Signed-off-by: Ashley Cui [email protected]

Fixes: #11680

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

@ashley-cui
Copy link
Member Author

@afbjorklund PTAL, let me know if any information is missing that should be included.

cc @baude

@rhatdan
Copy link
Member

rhatdan commented Oct 27, 2021

I definitely think this should be controlled by the user. Having all of your apps disappear because FCOS decides it is time to reboot is not a good experience.

@ashley-cui
Copy link
Member Author

I definitely think this should be controlled by the user. Having all of your apps disappear because FCOS decides it is time to reboot is not a good experience.

Yeah, I agree with this, probably a flag within podman machine init that allows for setting how the update reboot is done.

Update documentation on how the default podman machine distribution,
FCOS, is updated.

Signed-off-by: Ashley Cui <[email protected]>
@TomSweeneyRedHat
Copy link
Member

LGTM
would like a head nod from @afbjorklund

@afbjorklund
Copy link
Contributor

It looks good, although I'm not sure I would link to a specific stream of Fedora CoreOS (since it might change later?)

https://getfedora.org/en/coreos?stream=testing

It is of course true for now (at least for 3.4), so can update the documentation later if and when the default changes ?

Software updates generally follow the next → testing → stable flow

@rhatdan
Copy link
Member

rhatdan commented Oct 30, 2021

/approve
/lgtm
I agree we will have to change when we change the defaults.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-cui, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2021
@openshift-merge-robot openshift-merge-robot merged commit 85bad0c into containers:main Oct 30, 2021
@ashley-cui ashley-cui deleted the updates branch June 3, 2022 17:50
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add some documentation on how podman machine is updated
6 participants