Set flags to test 'logs -f' with journald driver #12118
Conversation
`logs -f` with `journald` is supported only when `journald` events backend is used. To pass system tests using `logs -f` in an environment where `events_logger` is not set to `journald` in `containers.conf`, this fix sets `--events-backend` or `--log-driver` temporally. Signed-off-by: Hironori Shiina <[email protected]>
|
Test failures look like network flakes, I've hit rerun |
| # Since PR#10431, 'logs -f' with journald driver is only supported with journald events backend. | ||
| if [[ $driver = "journald" ]]; then | ||
| run_podman info --format '{{.Host.EventLogger}}' >/dev/null | ||
| if [[ $output != "journald" ]]; then |
There was a problem hiding this comment.
Probably late-night brain malfunction on my part, but should this be == rather then !=?
There was a problem hiding this comment.
I think != is correct. When the event logger from containers.conf is NOT journald, I would like to add --events-backend jouranld so that logs -f works.
Thanks.
|
@edsantiago PTAL |
|
Tested via: # cat /etc/containers/containers.conf
[containers]
log_driver = "journald"
[engine]
events_logger = "file"Confirmed that tests 035-logs and 130-kill fail on main, and pass under this PR. Confirmed that all other system tests behave the same (as in: mostly pass, but fail due to some new I feel super uncomfortable about the number of incompatible (and untested) config permutations we're having. |
|
/lgtm Thank you @hshiina |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hshiina, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
Signed-off-by: Hironori Shiina [email protected]
What this PR does / why we need it:
logs -fwithjournaldis supported only whenjournaldevents backend is used. To pass system tests usinglogs -fin an environment whereevents_loggeris not set tojournaldincontainer.conf, this fix set--events-backendor--log-drivertemporally.How to verify it
035-logs.batswithcontainers.confwhereevents_loggeris notjournald.130-kill.batswithcontainers.confwhereevents_loggeris notjournaldandlog_driverisjournald.Which issue(s) this PR fixes:
None
Special notes for your reviewer: