Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Checkpointed state to false after restore #12117

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Set Checkpointed state to false after restore #12117

merged 1 commit into from
Oct 28, 2021

Conversation

adrianreber
Copy link
Collaborator

A restored container still had the state set to 'Checkpointed: true' which seems wrong if it running again.

@adrianreber
Set Checkpointed state to false after restore
dcbf5ca 
A restored container still had the state set to 'Checkpointed: true'
which seems wrong if it running again.

[NO NEW TESTS NEEDED]

Signed-off-by: Adrian Reber <[email protected]>
@mheon
Copy link
Member

mheon commented Oct 27, 2021

LGTM

@mheon
Copy link
Member

mheon commented Oct 27, 2021

Any value in adding a Restored bool, do you think? Wouldn't do it here, but I could look into it next time I'm working on the state.

@mheon
Copy link
Member

mheon commented Oct 27, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianreber, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2021
@Luap99
Copy link
Member

Luap99 commented Oct 27, 2021

Can you add a test for this?

@edsantiago
Copy link
Member

I have a test in #11957, but that PR can't merge until (I think?) crun gets fixed and updated on the CI VMs.

@TomSweeneyRedHat
Copy link
Member

LGTM
I'll let @mheon decide on the merge now or not.

vrothberg
vrothberg reviewed Oct 28, 2021
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2021
@mheon
Copy link
Member

mheon commented Oct 28, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2021
@openshift-merge-robot openshift-merge-robot merged commit d2147ba into containers:main Oct 28, 2021
@adrianreber
Copy link
Collaborator Author

Any value in adding a Restored bool, do you think? Wouldn't do it here, but I could look into it next time I'm working on the state.

Sounds like a useful idea.

@edsantiago edsantiago mentioned this pull request Nov 22, 2021
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

Assignees

@vrothberg vrothberg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@adrianreber @mheon @Luap99 @edsantiago @TomSweeneyRedHat @vrothberg @openshift-merge-robot