runtime: check for pause pid existence #12111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giuseppe Scrivano <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Luap99
reviewed
Oct 27, 2021
check that the pause pid exists before trying to move it to a separate scope. Closes: containers#12065 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
fix-warning-move-pause-process
branch
from
6b22331 to
6b3b0a1
Compare
vrothberg
reviewed
Oct 27, 2021
rhatdan
reviewed
Oct 27, 2021
| unified, err := cgroups.IsCgroup2UnifiedMode() | ||
| if err != nil { | ||
| unified, err2 := cgroups.IsCgroup2UnifiedMode() | ||
| if err2 != nil { | ||
| logrus.Warnf("Failed to detect if running with cgroup unified: %v", err) |
There was a problem hiding this comment.
I think in this case we want to report the original error of moving the PID to a different scope
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
drop undesired warning message
How to verify it
podman system reset -fdoesn't complain about moving the pause processWhich issue(s) this PR fixes:
Fixes #12065
Special notes for your reviewer: