Use socat while dial-stdio is not in VM image

[matejvasek]

The podman version in VM doesn't contain patch with dial-stdio yet.
To workaround we can use socat.

Once podman containing dial-stdio is in VM image we can revert this.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: matejvasek
To complete the pull request process, please assign saschagrunert after the PR has been reviewed.
You can assign the PR to them by writing /assign @saschagrunert in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[matejvasek]

I don't know how release cycle of Fedora Core VM works. I guess that podman in it is one or two release behind. This PR helps fix docker CLI issues little bit sooner before #11819 will be part of VM.

[afbjorklund]

It worked with the earlier releases, since it had the real docker. It was broken in b3307bc, that replaced it with podman

/usr/local/bin/docker -> /usr/bin/podman

[matejvasek]

It worked with the earlier releases, since it had the real docker. It was broken in b3307bc, that replaced it with podman

/usr/local/bin/docker -> /usr/bin/podman

@afbjorklund I didn't noticed when this changed. The podman system dial-stdio was merged only recently. Its advantage is that it should dial correct socket depending on user. Original docker CLI could do that too but you need set the DOCKER_HOST environment variable for user (like #12066).

[matejvasek]

So this PR should only bridge time between next release of podman and the release of fedora core image which would contain that podman. I think this should be fixed ASAP so people trying to switch to podman from docker desktop are not discouraged by the fact that docker CLI is not working.

[afbjorklund]

I think this should be fixed ASAP

Probably needs to be backported to 3.4, then a package release and then two weeks waiting ?

But I think people trying to use podman machine are used to breakages after the JSON thing.

Before podman dial-stdio, this was.

[matejvasek]

Probably needs to be backported to 3.4, then a package release and then two weeks waiting ?

I guess it will be in 3.4.2 and then latter in fedora core I don't know what's the delay.
Maybe two weeks? But I think even two weeks are worth.

But I think people trying to use podman machine are used to breakages after the JSON thing.

I thought that had been fixed, wasn't it?

[openshift-ci]

@matejvasek: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhatdan]

I think I would rather just add the podman containing dial-stdio to the next podman 3.4.3 release, then add something that needs to be removed. Since this is a hidden feature, I don't see this as a big change.

[rhatdan]

@mheon WDYT?

[mheon]

I don't think we can, we're feature-frozen as of now and this is definitely a new feature.

[rhatdan]

Then let's cut a new release with just this feature, for the MAC. 3.5.

[github-actions]

A friendly reminder that this PR had no activity for 30 days.

[rhatdan]

@matejvasek are you still working on this?

[matejvasek]

@rhatdan let me check current VM img, it may or may not be required anymore.

[matejvasek]

@rhatdan it looks like the dial-stdio (#11819) still hasn't been merged into some release, so this addition might be worthwhile.

[afbjorklund]

It wasn't going to be added until 3.5, and VM has 3.4.2

There also is the issue of host keys (with Docker), so the workaround is tunneling the Unix socket... Also fixes those API clients that don't support ssh://

(Podman ignores ssh host keys, but Docker does not)

[github-actions]

A friendly reminder that this PR had no activity for 30 days.

[rhatdan]

@afbjorklund @matejvasek Should be rebased or closed?

[afbjorklund]

I think unix:// tunneling is needed, the docker ssh:// support is not up to par.

Also it seemed like temporary hack, and one that was avoided intentionally by docker.

[matejvasek]

I wonder why #11819 was added to podman 4.X and not packported to 3.X.
It wasn't breaking any compatibility was it?

[mheon]

It's a new feature (new command), and we generally don't backport features

[afbjorklund]

It was going to be in podman 3.5, but I don't think it was important enough ?