Remove --kernel-memory options #12048
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
cmd/podman/common/create.go
Outdated
| @@ -319,6 +319,9 @@ func DefineCreateFlags(cmd *cobra.Command, cf *entities.ContainerCreateOptions, | |||
| "Kernel memory limit "+sizeWithUnitFormat, | |||
| ) | |||
| _ = cmd.RegisterFlagCompletionFunc(kernelMemoryFlagName, completion.AutocompleteNone) | |||
| // kernel-memory is depracated in the runtime spec. | |||
There was a problem hiding this comment.
nit: typo “depracated”
cmd/podman/common/create_opts.go
Outdated
| @@ -383,6 +384,9 @@ func ContainerCreateToContainerCLIOpts(cc handlers.CreateContainerConfig, rtc *c | |||
| if cc.HostConfig.Memory > 0 { | |||
| cliOpts.Memory = strconv.Itoa(int(cc.HostConfig.Memory)) | |||
| } | |||
| if cc.HostConfig.KernelMemory > 0 { | |||
| logrus.Warnf("The --kernel-memory flag has been depracated. May not work properly on your system.") | |||
| @@ -383,6 +384,9 @@ func ContainerCreateToContainerCLIOpts(cc handlers.CreateContainerConfig, rtc *c | |||
| if cc.HostConfig.Memory > 0 { | |||
| cliOpts.Memory = strconv.Itoa(int(cc.HostConfig.Memory)) | |||
| } | |||
| if cc.HostConfig.KernelMemory > 0 { | |||
| logrus.Warnf("The --kernel-memory flag has been deprecated. May not work properly on your system.") | |||
There was a problem hiding this comment.
Recommend rewording to "May not work properly with some OCI runtimes"
There was a problem hiding this comment.
Well it is not only the OCI Runtimes, even with crun, it is questionable whether or not the kernel works correctly when this is set in cgroupv2.
|
One nit otherwise LGTM |
|
@rhatdan, needs to be |
|
LGTM |
Kernel memory option has been depracated in runtime-spec, It is believed that it will not work properly on certain kernels. runc ignores it. This PR removes documentation of the flag and also prints a warning if a user uses it. [NO NEW TESTS NEEDED] Helps Fix: containers#12045 Signed-off-by: Daniel J Walsh <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Kernel memory option has been depracated in runtime-spec, It is
believed that it will not work properly on certain kernels. runc
ignores it.
This PR removes documentation of the flag and also prints a warning if
a user uses it.
[NO NO TESTS NEEDED]
Helps Fix: #12045
Signed-off-by: Daniel J Walsh [email protected]
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer: