Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for system connection #12028

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Add test for system connection #12028

merged 1 commit into from
Oct 21, 2021

Conversation

edsantiago
Copy link
Member

First a basic (connectionless) one to make sure we 'add', 'ls',
and 'rm' work; then an actual one with a service; then (if
ssh to localhost is set up and works) test ssh

Signed-off-by: Ed Santiago [email protected]

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2021
@mheon
Copy link
Member

mheon commented Oct 18, 2021

LGTM, but I think we need @jwhonce to review before merge

@edsantiago
Copy link
Member Author

Urgh. The --url in the definition of $PODMAN_REMOTE is overriding the connection type. I need to rethink this. Tomorrow.

@edsantiago edsantiago force-pushed the test_system_connection branch from 365e7dd to db9b7aa Compare October 19, 2021 01:19
@edsantiago
Copy link
Member Author

/hold

My idea worked, but I don't especially like it. I have an idea on how to refactor it but definitely not tonight.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2021
@edsantiago edsantiago force-pushed the test_system_connection branch from db9b7aa to bb52344 Compare October 19, 2021 11:52
@edsantiago
Copy link
Member Author

/hold cancel

@jwhonce PTAL

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2021
@edsantiago
Add test for system connection
d24ce0a 
First a basic (connectionless) one to make sure we 'add', 'ls',
and 'rm' work; then an actual one with a service; then (if
ssh to localhost is set up and works) test ssh

Requires a little trickery to work around the CI definition
of $PODMAN, which includes "--url /path/to/sock", which
overrides podman's detection of whether to use a connection
or not.

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago edsantiago force-pushed the test_system_connection branch from bb52344 to d24ce0a Compare October 19, 2021 15:19
@edsantiago
Copy link
Member Author

Rebased and cleaned up to adjust for #12027

@TomSweeneyRedHat
Copy link
Member

LGTM and happy green test buttons
@jwhonce PTAL and merge if it LGTY

@rhatdan
Copy link
Member

rhatdan commented Oct 21, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2021
@openshift-merge-robot openshift-merge-robot merged commit 6338e74 into containers:main Oct 21, 2021
@edsantiago edsantiago deleted the test_system_connection branch October 21, 2021 14:18
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jwhonce jwhonce

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@edsantiago @mheon @TomSweeneyRedHat @rhatdan @jwhonce @openshift-merge-robot