Generate Kube should not print default structs

[rhatdan]

If podman uses Workdir="/" or the workdir specified in the image, it
should not add it to the yaml.
If Podman find environment variables in the image, they should not
get added to the yaml.

If the container or pod do not have changes to SELinux we should not
print seLinuxOpt{}

If the container or pod do not change any dns options the yaml should
not have a dnsOption={}

If the container is not privileged it should not have privileged=false
in the yaml.

Fixes: #11995

Signed-off-by: Daniel J Walsh [email protected]

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dilyanpalauzov]

Any idea what is the default for allowPrivilegeEscalation? The Kubernetes documentation is unclear - kubernetes/website#30104 .

[rhatdan]

It is allowed by default. @umohnani8 @haircommander @mrunalp Correct.

[haircommander]

yeah it's on by default, though there is a PSP field that allows you to turn it off for any pod that uses the PSP (DefaultAllowPrivilegeEscalation)

[haircommander]

indentation here is funky

[haircommander]

what type is imgData.Config.WorkingDir that requires a deep equal here? can't it be cast to a string, which I assume will be less expensive?

[rhatdan]

Just cut and paste, I will fix it.

[rhatdan]

@jwhonce Do you know an easy way to drop the remaining {} fields from podman generate kube.

$ ./bin/podman generate kube dan
# Save the output of this file and use kubectl create -f to import
# it into Kubernetes.
#
# Created with podman-4.0.0-dev
apiVersion: v1
kind: Pod
metadata:
  creationTimestamp: "2021-10-19T12:40:10Z"
  labels:
    app: dan
  name: dan
spec:
  containers:
  - command:
    - echo
    - hi
    image: registry.fedoraproject.org/fedora:latest
    name: dan
    resources: {}
    securityContext:
      capabilities:
        drop:
        - CAP_MKNOD
        - CAP_NET_RAW
        - CAP_AUDIT_WRITE
status: {}

In the print out above I would want to remove
resource{}
and
status: {}

I think this is something we would need to do in the filters. Within code, I don't believe we can change them to nil.

[rhatdan]

@containers/podman-maintainers PTAL
@umohnani8 PTAL

[vrothberg]

LGTM

[umohnani8]

/lgtm