If CONTAINER_HOST env variable is set default podman --remote=true

[rhatdan]

Users enabling CONTAINER_HOST==PATH is indicating to podman they intend
to use remote functionality.

Fixes: #11196

Signed-off-by: Daniel J Walsh [email protected]

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Luap99]

Should we do the same for CONTAINER_CONNECTION?

[rhatdan]

Yes and that does not seem to be documented anywhere.

[TomSweeneyRedHat]

I'm not parsing much of this.

Suggested change

	When CONTAINER_HOST environment variable is set default to true.
	When true, access to the Podman service will be remote. When the CONTAINER_HOST environment variable is set, the remote option defaults to true. Remote connections use the local containers.conf file by default.

Is remote false by default or set from containers.conf? That should be added.

[rhatdan]

@containers/podman-maintainers PTAL

[ashley-cui]

LGTM

[vrothberg]

LGTM but I want a final head nod from @jwhonce

[jwhonce]

/lgtm

[Luap99]

I do not think this works. Remote must be parsed before any cli commands are defined. The code handles this in a special way here:

podman/cmd/podman/registry/remote.go

Line 20 in 171f7b8

func IsRemote() bool {

This is because the cli changes depending if we are remote or not, so when cobra parsed the --remote flag it is already to late.