Don't include ctr.log if not using file logging #11977
Conversation
openshift-ci
bot
added
the
approved
Checkpoint is blowing up when you use --log-driver=none [NO NEW TESTS NEEDED] No way currently to test checkpoint restore. Fixes: containers#11974 Signed-off-by: Daniel J Walsh <[email protected]>
rhatdan
changed the title
|
@adrianreber No idea if this fixes the issue, but it seemed logical. |
|
@ carlhoerberg any chance you could check this code out and rebuild Podman to see if this fixes your issue. I know nothing about this area of code. but this looked logical. |
|
Looks correct. |
|
LGTM, but definitely would like this tested against the issue. |
Hold my 🍺: https://github.com/containers/podman/blob/main/test/e2e/checkpoint_test.go |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
the
locked - please file new issue/PR
Checkpoint is blowing up when you use --log-driver=none
[NO NEW TESTS NEEDED] No way currently to test checkpoint restore.
Fixes: #11974
Signed-off-by: Daniel J Walsh [email protected]
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer: