Use CGO_ENABLED=1 when building natively on darwin

[jwhonce]

Need to use CGO for mDNS resolution, but cross builds need CGO disabled
See golang/go#12524 for details

Note: Homebrew forumla will need to be updated to pick up this change

Fixes #10737

Signed-off-by: Jhon Honce [email protected]

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jwhonce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

LGTM

[ashley-cui]

CI :'(

[cevich]

Yeah, this is what I was afraid of. And the sentiment I've run into generally is that CGO is evil and bad and should be avoided at all costs 😕

Looking at the diff, I wonder if the conditional is needed at all. I think you can simply set CGO_ENABLED=1 in podman-remote-darwin since that target will never ever be used for anything but darwin. In other words, I question if CGO_ENABLED=whatever has any impact based on if we're cross-compiling or not.

In case it helps you cycle faster: You can temporarily trick CI into only running certain tasks by making them skip: $CI == $CI. You'll need to fight with the YAML anchors/aliases a bit. But this will let you (for example) only run the "OSX Cross" and "Alt Arch. Cross" tasks instead of waiting for everything else.

[cevich]

Maybe it doesn't help, but there is a native mDNS package available: https://pkg.go.dev/github.com/hashicorp/mdns

S'pose a call to it would need to be grafted in every single damn place a name-lookup is made 😕

But then at least CGO isn't needed 😁

[TomSweeneyRedHat]

LGTM
once the CI is righted.

[rhatdan]

/lgtm

[rhatdan]

@ashley-cui Can we get a new brew build done of podman for MAC?

[zeha]

@jwhonce could we get this backported into 3.4 please?

[rhatdan]

@zeha open a PR.