Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use docker/pkg/archive, use containers/storage/pkg/archive #11971

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Oct 14, 2021

[NO NEW TESTS NEEDED]

Signed-off-by: Daniel J Walsh [email protected]

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

[NO NEW TESTS NEEDED]

Signed-off-by: Daniel J Walsh <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2021
@rhatdan
Copy link
Member Author

rhatdan commented Oct 14, 2021

@nalind Any idea why imagebuilder uses
docker "github.com/fsouza/go-dockerclient"

This end up pulling in all of the docker archive stuff into Podman.

@mheon
Copy link
Member

mheon commented Oct 14, 2021

LGTM

@nalind
Copy link
Member

nalind commented Oct 14, 2021

@nalind Any idea why imagebuilder uses docker "github.com/fsouza/go-dockerclient"

It connects to a docker daemon, and the package offers an API for doing that. Some of its types (Config and Image) are baked into imagebuilder's exported API, so it can't easily be replaced with something else.

@TomSweeneyRedHat
Copy link
Member

LGTM

@TomSweeneyRedHat
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2021
@openshift-merge-robot openshift-merge-robot merged commit 77ae43a into containers:main Oct 14, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants