Fix codespell errors #11967
Merged
Fix codespell errors #11967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
edsantiago
reviewed
Oct 14, 2021
pkg/specgen/specgen.go
Outdated
| @@ -551,7 +551,7 @@ func NewSpecGenerator(arg string, rootfs bool) *SpecGenerator { | |||
| csc := ContainerStorageConfig{} | |||
| if rootfs { | |||
| csc.Rootfs = arg | |||
| // check if rootfs is actually overlayed | |||
| // check if rootfs is should use overlay | |||
There was a problem hiding this comment.
I think this should be corrected to is actually overlay (remove the ed), but if not, please remove the is
Along with a couple of nits found by Ed. [NO NEW TESTS NEEDED] Signed-off-by: Daniel J Walsh <[email protected]>
| @@ -222,7 +222,7 @@ var _ = Describe("Podman run with volumes", func() { | |||
| Expect(matches[0]).To(Not(ContainSubstring("nosuid"))) | |||
| }) | |||
|
|
|||
| // Container should start when workdir is overlayed volume | |||
| // Container should start when workdir is overlay volume | |||
There was a problem hiding this comment.
Suggested change
| // Container should start when workdir is overlay volume | |
| // Container should start when workdir is an overlay volume |
|
LGTM |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with a couple of nits found by Ed.
[NO NEW TESTS NEEDED]
Signed-off-by: Daniel J Walsh [email protected]
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer: