Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builder: Add support for builder prune #11932

Merged
merged 1 commit into from
Oct 12, 2021
Merged

builder: Add support for builder prune #11932

merged 1 commit into from
Oct 12, 2021

Conversation

flouthoc
Copy link
Collaborator

Docker has support for docker builder prune and
docker builder build

This patch will add a hidden command to support scripts using this
syntax. We don't want to encourage this deviation.

Add podman build prune to implement docker builder prune
functionality.

Closes: #11744

@flouthoc flouthoc force-pushed the build-prune branch 3 times, most recently from 9eb286a to 7697f38 Compare October 12, 2021 07:58
@flouthoc
Copy link
Collaborator Author

Refraining from adding --keep-storage since behavior is highly undocumented and for podman it seems non applicable since we don't limit build cache size. Since its hidden i doubt if it is being used. If users report for this we can add this option later.

@flouthoc flouthoc force-pushed the build-prune branch 4 times, most recently from bdc918b to 7b2c734 Compare October 12, 2021 08:56
@flouthoc flouthoc requested a review from vrothberg October 12, 2021 08:58
vrothberg
vrothberg reviewed Oct 12, 2021
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @flouthoc !

@flouthoc
Copy link
Collaborator Author

flouthoc commented Oct 12, 2021 •
edited
Loading

ah i guess still needs extra doc md file. Since podman build prune is not hidden.

Edit: Just checked docker also have this as a hidden field. docker build prune is not available only docker builder prune is available hence making it same for podman.

@flouthoc @rhatdan
builder: Add support for builder prune
ab8fb38 
Docker has support for docker builder prune and
docker builder build

This patch will add a hidden command to support scripts using this
syntax. We don't want to encourage this deviation.

Add podman build prune to implement docker builder prune
functionality.

Co-authored-by: Daniel J Walsh <[email protected]>
Signed-off-by: Aditya Rajan <[email protected]>
@flouthoc
Copy link
Collaborator Author

@rhatdan @vrothberg PTAL

@flouthoc flouthoc requested a review from vrothberg October 12, 2021 15:22
@rhatdan
Copy link
Member

rhatdan commented Oct 12, 2021

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2021
@openshift-merge-robot openshift-merge-robot merged commit 214c13d into containers:main Oct 12, 2021
@edsantiago edsantiago mentioned this pull request Nov 3, 2021
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for podman builder/ podman builder prune
4 participants
@flouthoc @rhatdan @vrothberg @openshift-merge-robot