Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SplitN(2) when copying env variables #11920

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

jwhonce
Copy link
Member

@jwhonce jwhonce commented Oct 11, 2021

Environment variables whose value contained an equal sign where
truncated

Fixes #11891

Signed-off-by: Jhon Honce [email protected]

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Environment variables whose value contained an equal sign where
truncated

Fixes containers#11891

Signed-off-by: Jhon Honce <[email protected]>
@jwhonce jwhonce added the kind/bug Categorizes issue or PR as related to a bug. label Oct 11, 2021
@jwhonce jwhonce requested a review from baude October 11, 2021 16:15
@jwhonce jwhonce self-assigned this Oct 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2021
@rhatdan
Copy link
Member

rhatdan commented Oct 11, 2021

LGTM

@Luap99
Copy link
Member

Luap99 commented Oct 11, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2021
@openshift-merge-robot openshift-merge-robot merged commit 2fcec59 into containers:main Oct 11, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podman play kube truncates env parameters
4 participants