Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] oci-hooks.5.md: fixup section in header #11904

Merged
merged 1 commit into from
Oct 10, 2021

Conversation

siretart
Copy link
Contributor

@siretart siretart commented Oct 9, 2021

This fixes the autodetection of where to install the manpages

Signed-off-by: Reinhard Tartler [email protected]

What this PR does / why we need it:

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

@mheon
Copy link
Member

mheon commented Oct 9, 2021

CI is complaining about a missing signoff - can you do a git commit --amend -s and force-push?
/approve
LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, siretart

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2021
@rhatdan
Copy link
Member

rhatdan commented Oct 10, 2021

LGTM
Just fix the commit message.

This fixes the autodetection of where to install the manpages

Signed-off-by: Reinhard Tartler <[email protected]>
@Luap99
Copy link
Member

Luap99 commented Oct 10, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2021
@openshift-merge-robot openshift-merge-robot merged commit ea86893 into containers:main Oct 10, 2021
@siretart siretart deleted the patch-2 branch October 10, 2021 16:01
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants