cirrus: gitlab: download packages #11821
Conversation
It looks like the containerd.io package is not present anymore in the package cache which ultimately breaks CI since it's a requirement for docker. Hence, download the few packages instead of relying on the cache. Signed-off-by: Valentin Rothberg <[email protected]>
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| # N/B: Tests check/expect `docker info` output, and this `!= podman info` | ||
| ooe.sh apt-get install --yes --no-download --ignore-missing containerd.io docker-ce docker-ce-cli | ||
| ooe.sh apt-get install --yes containerd.io docker-ce docker-ce-cli |
There was a problem hiding this comment.
@vrothberg the point of caching these packages and installing with --no-download is to prevent them from changing unexpectedly or crashing/burning due to remote repo. unavailability. While this is a fine fix for now (un-stucking CI is important), in the future I would appreciate a #FIXME comment or opening an issue in https://github.com/containers/automation_images so I can fix the underlying issue. I'll do that now, but you owe me a cookie 😁
There was a problem hiding this comment.
Oh, and thanks for fixing this. I do appreciate it.
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh! The "proper" fix here is actually really easy: #11834 Just took me 4 hours of reading man pages and stackoverflow to realize...we don't need to use apt-get 😁
/me munches his own 🍪
There was a problem hiding this comment.
Great news, thanks for digging into it, @cevich!
Original workaround containers#11821 During VM image build, a number of packages are downloaded but not installed, since they may interfere with some testing. Then at runtime, where required, the packages are installed from cache and used. However, between image build and runtime it's possible the repository contents change, which will invalidate the package cache. Since the `--no-download --ignore-missing` options were used, the install will fail. Ref: containers/automation_images#95 Fortunately, when it comes to the docker packages, no other dependencies are required and so `apt-get` isn't required. Switch to using a simple dpkg install command on the necessary files. If this ever breaks due to new dependencies, the list of files may simply be updated. Signed-off-by: Chris Evich <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
It looks like the containerd.io package is not present anymore in the
package cache which ultimately breaks CI since it's a requirement for
docker.
Hence, download the few packages instead of relying on the cache.
Signed-off-by: Valentin Rothberg [email protected]