Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor in containers/common v0.46.0 #11746

Closed
wants to merge 1 commit into from
Closed

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Sep 26, 2021

Fixes: #11745

Signed-off-by: Daniel J Walsh [email protected]

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2021
@zhangguanzhang
Copy link
Collaborator

maybe need NO-TEST-NEEDED title?

Fixes: containers#11745

[NO TESTS NEEDED] Since this is just a revendor and a one line
change for the revendor

Signed-off-by: Daniel J Walsh <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aniruddhabagal, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrothberg
Copy link
Member

@rhatdan the error changes broke test/system/330-corrupt-images.bats. We need to adjust the check there.

@vrothberg
Copy link
Member

I'm taking over to speed things up.

@vrothberg vrothberg closed this Sep 27, 2021
@vrothberg vrothberg reopened this Sep 27, 2021
@vrothberg
Copy link
Member

Opened #11753

@rhatdan the error changes broke test/system/330-corrupt-images.bats. We need to adjust the check there.

It was actually the load error, fixed now.

@vrothberg vrothberg closed this Sep 27, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to decode the keys ["machine"]
4 participants