Fix up docker compatibility messages #1170
Conversation
Signed-off-by: Daniel J Walsh <[email protected]>
|
LGTM I assume the libpod.conf manpage is removed intentionally? A general question: as the files are renamed, wouldn't it makes to also |
|
@vrothberg No the idea is to make sure people know they are using podman, We don't want them to think they are using docker. That would be considered dishonest. We want them to know they are using podman, but if they cut and paste a command from google, or just do it by accident, or have scripts hard coded to run the Docker CLI, we want them to work without having to sed 's/docker/podman in their scripts. |
|
There is no equivalent for libpod.conf in docker. |
| @@ -232,9 +232,7 @@ install.cni: | |||
| install.docker: docker-docs | |||
| install ${SELINUXOPT} -D -m 755 docker $(BINDIR)/docker | |||
| install ${SELINUXOPT} -d -m 755 $(MANDIR)/man1 | |||
| install ${SELINUXOPT} -d -m 755 $(MANDIR)/man5 | |||
There was a problem hiding this comment.
Do you really want to remove this?
There was a problem hiding this comment.
Yes, their are no man5 man pages.
There was a problem hiding this comment.
As @vrothberg pointed out, we're currently shipping libpod.conf.5. Do we want to stop shipping that?
There was a problem hiding this comment.
No. That is not installed here, it is installed in the standard install. This is just about installing links for Docker alias, so people accidently typing docker commands or man docker build, will get information back.
|
Code LGTM |
|
@rh-atomic-bot r=mheon |
|
📌 Commit c9a3480 has been approved by |
|
LGTM, thx for the links 411 |
|
☀️ Test successful - status-papr |
github-actions
bot
added
the
locked - please file new issue/PR
Signed-off-by: Daniel J Walsh [email protected]