podman save: add --uncompressed

[vrothberg]

Add an option to podman save to allow uncompressed layers when
copying OCI images. Do the neccessary plumbing for the remote client,
add tests and vendor in the latest commit from c/common to fetch
the neccessary changes in libimage.

Closes: #11613
Signed-off-by: Valentin Rothberg [email protected]

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

You must be a better typer then me. Can we just use --uncompressed. I hate options with embeded "-" and I hate long hard to type options. (I know we have command completion.

[umohnani8]

LGTM

[vrothberg]

You must be a better typer then me. Can we just use --uncompressed. I hate options with embeded "-" and I hate long hard to type options. (I know we have command completion.

@mtrmac WDYT?

[TomSweeneyRedHat]

LGTM
I'm fine with either option.

[vrothberg]

Updated @rhatdan PTAL

[rhatdan]

/lgtm

[rhatdan]

I have one question, event though I gave you a LGTM? When would a user want --uncompressed=false?
Why would a user care?

[vrothberg]

I have one question, event though I gave you a LGTM? When would a user want --uncompressed=false?
Why would a user care?

=false is the default so by default OCI archives will be compressed. That's how Podman behaved so far and I think it's worth preserving for backwards compat. I also see beauty in compressing since it decreases size but if users don't need to care about that, they set --uncompressed=true.