Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System tests: cleanup, and remove obsolete skips #11638

Merged
merged 1 commit into from
Sep 18, 2021

Conversation

edsantiago
Copy link
Member

  • 070-build:

    • remove workaround for CI: Ubuntu 2004 is slow #9567, which is closed.
    • add many more cases to the ignorefile test,
      to test complicated special cases of Buildah PR 3486.
  • 160-volumes:

    • remove a skip_if_remote, volumes now work on remote
    • use a random name for tarball, and clean up when
      done using it. This fixes a gating-test failure
      (test runs as root, then rootless, and rootless
      can't clobber root's file).

Signed-off-by: Ed Santiago [email protected]

* 070-build:
  - remove workaround for containers#9567, which is closed.
  - add many more cases to the ignorefile test,
    to test complicated special cases of Buildah PR 3486.

* 160-volumes:
  - remove a skip_if_remote, volumes now work on remote
  - use a random name for tarball, and clean up when
    done using it. This fixes a gating-test failure
    (test runs as root, then rootless, and rootless
    can't clobber root's file).

Signed-off-by: Ed Santiago <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2021
@rhatdan
Copy link
Member

rhatdan commented Sep 17, 2021

LGTM

@edsantiago
Copy link
Member Author

Looks like a new flake (I hope) in unshare, int, f33 rootless:

Running: podman [options] unshare false
         time="2021-09-17T15:59:56-05:00" level=warning msg="Failed to add pause process to systemd sandbox cgroup: mkdir /sys/fs/cgroup/devices/user.slice/user-11239.slice: permission denied"

I have not seen that before. Restarting, with fingers crossed.

@rhatdan
Copy link
Member

rhatdan commented Sep 18, 2021

Sadly we are seeing the podman unshare flake a lot.

@TomSweeneyRedHat
Copy link
Member

LGTM

@TomSweeneyRedHat
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2021
@openshift-merge-robot openshift-merge-robot merged commit ddb3844 into containers:main Sep 18, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants