Add support for retrieving system service --timeout #11630
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Any doc/man page changes? |
| timeFlagName := "time" | ||
| flags.Int64VarP(&srvArgs.Timeout, timeFlagName, "t", 5, "Time until the service session expires in seconds. Use 0 to disable the timeout") |
There was a problem hiding this comment.
Does this actually work? This flag requires an argument, and it's not enabled unless explicitly specified. The default is always going to be overridden?
There was a problem hiding this comment.
Yes that is how it works. The same logic is used for many flags in other commands.
There was a problem hiding this comment.
So - how does this help us, then? The unit file is going to have to specify -t <value> which overrides the default we're setting here, so containers.conf is getting ignored.
There was a problem hiding this comment.
Which unit includes the -t flag?
$ systemctl cat podman.service
# /usr/lib/systemd/system/podman.service
[Unit]
Description=Podman API Service
Requires=podman.socket
After=podman.socket
Documentation=man:podman-system-service(1)
StartLimitIntervalSec=0
[Service]
Type=exec
KillMode=process
Environment=LOGGING="--log-level=info"
ExecStart=/usr/bin/podman $LOGGING system service
[Install]
WantedBy=multi-user.target
There was a problem hiding this comment.
There was a problem hiding this comment.
OH - having a timeout is the default, you have to explicitly opt out with -t 0.
OK, this works, then. Nevermind.
rhatdan
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
rhatdan
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Daniel J Walsh <[email protected]>
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Signed-off-by: Daniel J Walsh [email protected]