Backports and release notes for v3.4.0-RC1 #11598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
Luap99
reviewed
Sep 15, 2021
|
@baude @TomSweeneyRedHat PTAL at the release notes please |
mheon
force-pushed
the
34_backportsreleasenotes
branch
from
cbca151 to
fa95b3f
Compare
|
The build each commit job appears to be busted, it's building commits from last year. |
These are not presently functional - we need a rewrite of how the pod cgroup is handled first. Signed-off-by: Matthew Heon <[email protected]>
Signed-off-by: Matthew Heon <[email protected]>
Signed-off-by: Paul Holzinger <[email protected]>
When using the defaut conection for podman machine ssh, use the default username too. Signed-off-by: Ashley Cui <[email protected]>
fixes: containers#11540 Signed-off-by: Daniel J Walsh <[email protected]>
Signed-off-by: Jason Greene <[email protected]>
Closes containers#11531 [NO TESTS NEEDED] Signed-off-by: Hyeon Kim <[email protected]>
and fix it for running with runc. Closes: containers#11165 Signed-off-by: Giuseppe Scrivano <[email protected]>
When we restart a container via podman restart or restart policy the rootlessport process fails with `address already in use` because the socketfile still exists. This is a regression and was introduced in commit abdedc3. Signed-off-by: Paul Holzinger <[email protected]>
When a container is automatically restarted due its restart policy and the container uses rootless cni networking with ports forwarded we have to start a new rootlessport process since it exits with conmon. Signed-off-by: Paul Holzinger <[email protected]>
For rootful users ports are forwarded via iptables. To make sure no other process tries to use them, libpod will bind the ports and pass the fds to conmon. There seems to be race when a container is restarted because libpod tries to bind the port before the conmon process exited. The problem only hapens with the podman service because it keeps the connection open. Once we have the fd and passed it to conmon the podman service should close the connection. To verify run `sudo ss -tulpn` and check that only the conmon process keeps the port open. Previously you would also see the podman server process listed. Signed-off-by: Paul Holzinger <[email protected]>
Ref: containers/automation_images#88 Signed-off-by: Chris Evich <[email protected]>
* Follow https://pkg.go.dev/cmd/go#hdr-Generate_Go_files_by_processing_source for leading comment * Add godoc strings for all exposed methods for IDE support * Copy field godoc strings into generated code as function godoc string * Remove unused/unnecessary fields from generator.go structures * Cleanup code regarding template usage Signed-off-by: Jhon Honce <[email protected]>
read the cgroup directly from the container. Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Jelle van der Waa <[email protected]>
Fixes containers#11582 Signed-off-by: Paul Holzinger <[email protected]>
|
Build each commit now complaining about a commit that doesn't exist in the tree... |
mheon
force-pushed
the
34_backportsreleasenotes
branch
from
fa95b3f to
0a6ab91
Compare
|
@cevich PTAL |
|
I can reproduce the |
|
So it's just reporting the wrong commit hashes? Lovely... |
When `?all=garbage` is passed to an API endpoint schema validation fails and err is nil. Wrapf uses err to create an error message causing a nil pointer dereference. Signed-off-by: Jelle van der Waa <[email protected]>
Along with the name (id) and the version(_id) But only show the information if is available Examples: Fedora CoreOS, Ubuntu Focal [NO TESTS NEEDED] Signed-off-by: Anders F Björklund <[email protected]>
Signed-off-by: Matthew Heon <[email protected]>
Signed-off-by: Matthew Heon <[email protected]>
Following commit makes sure that podman mirrors --authfile to a temporary file in filesystem if arg is pointing to an FD instead of actual file as FD can be only consumed once. Reference: * containers/buildah#3498 * containers/buildah#3070 [NO TESTS NEEDED] Signed-off-by: Aditya Rajan <[email protected]>
Fix copy tests after containers/buildah#3486 [NO TESTS NEEDED] Signed-off-by: Aditya Rajan <[email protected]>
The builder can take a list of platforms in the Platforms field of its BuildOptions argument, and we should definitely take advantage of that. The `bud-multiple-platform-values` test from buildah exercises support for this, so [NO TESTS NEEDED] Signed-off-by: Nalin Dahyabhai <[email protected]>
Honor --cgroups=split also when the container is running in a pod. Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Matthew Heon <[email protected]>
Signed-off-by: Matthew Heon <[email protected]>
Signed-off-by: Matthew Heon <[email protected]>
Signed-off-by: Matthew Heon <[email protected]>
mheon
force-pushed
the
34_backportsreleasenotes
branch
from
0a6ab91 to
a647e1d
Compare
|
I don't understand your comment. |
|
It looks like you are missing the --ssh option in the podman build page. https://github.com/containers/podman/blob/main/docs/source/markdown/podman-build.1.md#--sshdefaultidsocket |
|
@edsantiago Cirrus' build-each-commit job was giving me SHAs that don't exist in the tree - so perhaps it works locally, but it decidedly does not on upstream CI. |
Signed-off-by: Matthew Heon <[email protected]>
|
I think CI is starting to pass. |
|
The |
|
Buildah tests failing - probably need to copy those from main as well. |
Signed-off-by: Matthew Heon <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says.
Let's hope CI is happy.