If container exits with 125 podman should exit with 125

[rhatdan]

fixes: #11540

Signed-off-by: Daniel J Walsh [email protected]

[rhatdan]

@jwhonce Any remembrance why you added this code?

diff --git a/cmd/podman/root.go b/cmd/podman/root.go
index 371ded9a8..cf712aa90 100644
--- a/cmd/podman/root.go
+++ b/cmd/podman/root.go
@@ -90,13 +90,6 @@ func init() {
 func Execute() {
        if err := rootCmd.ExecuteContext(registry.GetContextWithOptions()); err != nil {
                fmt.Fprintln(os.Stderr, formatError(err))
-       } else if registry.GetExitCode() == registry.ExecErrorCodeGeneric {
-               // The exitCode modified from registry.ExecErrorCodeGeneric,
-               // indicates an application
-               // running inside of a container failed, as opposed to the
-               // podman command failed.  Must exit with that exit code
-               // otherwise command exited correctly.
-               registry.SetExitCode(0)
        }
        os.Exit(registry.GetExitCode())
 }

[TomSweeneyRedHat]

Changes LGTM but tests are unhappy and one comment that needs to be addressed.

[rhatdan]

@Luap99 PTAL

[Luap99]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99,rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Luap99]

/lgtm