Code

Fix HTTP credentials passing#11538

Code

Merged

openshift-merge-robot merged 27 commits intocontainers:maincontainers/podman:mainfrom mtrmac:http-credentialsmtrmac/libpod:http-credentialsCopy head branch name to clipboardJan 6, 2022

+503-155

Commits

Commits on Dec 10, 2021

• Add unit tests for multiAuthHeader

  Show description for b162d88
  mtrmac

  committed
  b162d88

• Add unit tests for singleAuthHeader

  Show description for ff00392
  mtrmac

  committed
  ff00392

• Improve TestAuthConfigsToAuthFile

  Show description for 5a5aa60
  mtrmac

  committed
  5a5aa60

• Add tests for auth.Header

  Show description for ad7e5e3
  mtrmac

  committed
  ad7e5e3

• Add TestHeaderGetCredentialsRoundtrip

  Show description for d29a4a6
  mtrmac

  committed
  d29a4a6

• Rename normalize and a few variables

  Show description for 1b6bf97
  mtrmac

  committed
  1b6bf97

• Fix normalizeAuthFileKey to use the correct semantics

  Show description for 491951d
  mtrmac

  committed
  491951d

• Don't return a header name from auth.GetCredentials

  Show description for 2aeb690
  mtrmac

  committed
  2aeb690

• Simplify the interface of parseSingleAuthHeader

  Show description for 7674f2f
  mtrmac

  committed
  7674f2f

• Simplify parseSingleAuthHeader

  Show description for 6f1a26b
  mtrmac

  committed
  6f1a26b

• Pass a header value directly to parseSingleAuthHeader and parseMultiAuthHeader

  Show description for 1ecc6ba
  mtrmac

  committed
  1ecc6ba

• Beautify GetCredentials.has a bit

  Show description for 2946e83
  mtrmac

  committed
  2946e83

• Use Header.Values in GetCredentials.has

  Show description for 1589d70
  mtrmac

  committed
  1589d70

• Only look up HTTP header values once in GetCredentials

  Show description for da86a23
  mtrmac

  committed
  da86a23

• Consolidate the error handling path in GetCredentials

  Show description for 9d56ebb
  mtrmac

  committed
  9d56ebb

• Move the auth file creation to GetCredentials

  Show description for 29f4088
  mtrmac

  committed
  29f4088

• Turn headerConfig into MakeXRegistryConfigHeader

  Show description for 8155fb5
  mtrmac

  committed
  8155fb5

• Call MakeXRegistryConfigHeader instead of Header(..., XRegistryConfigHeader)

  Show description for d073b12
  mtrmac

  committed
  d073b12

• Turn headerAuth into MakeXRegistryAuthHeader

  Show description for 78dd797
  mtrmac

  committed
  78dd797

• Call MakeXRegistryAuthHeader instead of Header(..., XRegistryAuthHeader)

  Show description for 3725a34
  mtrmac

  committed
  3725a34

• Remove pkg/auth.Header

  Show description for fe1230e
  mtrmac

  committed
  fe1230e

• Consolidate creation of SystemContext with auth.json into a helper

  Show description for 0e29b89
  mtrmac

  committed
  0e29b89

• Remove no-longer-useful name variables

  Show description for 935dcbb
  mtrmac

  committed
  935dcbb

• Remove the authfile parameter of MakeXRegistryConfigHeader

  Show description for f9be326
  mtrmac

  committed
  f9be326

• Simplify the header decision in pkg/bindings/images.Build a bit

  Show description for d79414c
  mtrmac

  committed
  d79414c

• Remove the authfile parameter of MakeXRegistryAuthHeader

  Show description for 3cfefa1
  mtrmac

  committed
  3cfefa1

• Make XRegistryAuthHeader and XRegistryConfigHeader private

  Show description for 5bbcfaf
  mtrmac

  committed
  5bbcfaf