Remove changelog.txt from the repository #11467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Controversial, so /assign mheon |
|
I'm fine with this. One less step to do as part of the release process. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jesperpedersen, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Gitvalidation is complaining:
|
The changelog.txt file hasn't been kept in sync with release tags, especially on main, so remove it. The release notes will be featured in RELEASE_NOTES.md. Signed-off-by: jesperpedersen <[email protected]> [NO TESTS NEEDED]
jesperpedersen
force-pushed
the
changelog
branch
from
a6bad30 to
0d1ba0a
Compare
|
/lgtm |
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Oct 5, 2021
Accept both "NO TESTS NEEDED" and "NO NEW TESTS NEEDED". That was a usability mistake I made on Day One. Fixed it in Buildah but oops never got around to fixing it here. Also, fix the test suite script: remove a no-longer-working test case (changelog.txt, removed in containers#11467) and add a new test for commits that include the magic string. Signed-off-by: Ed Santiago <[email protected]>
mheon
pushed a commit
to mheon/libpod
that referenced
this pull request
Oct 19, 2021
Accept both "NO TESTS NEEDED" and "NO NEW TESTS NEEDED". That was a usability mistake I made on Day One. Fixed it in Buildah but oops never got around to fixing it here. Also, fix the test suite script: remove a no-longer-working test case (changelog.txt, removed in containers#11467) and add a new test for commits that include the magic string. Signed-off-by: Ed Santiago <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as it isn't been kept in sync with release tags, especially on main.
The release notes will be featured in RELEASE_NOTES.md.
Signed-off-by: jesperpedersen [email protected]
[NO TESTS NEEDED]