generate systemd: handle --restart #11459
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@Luap99 PTAL |
|
Added a bunch of new tests on top. |
|
LGTM |
| if err := validateRestartPolicy(info.RestartPolicy); err != nil { | ||
| return "", err | ||
| if options.RestartPolicy != nil { | ||
| if err := validateRestartPolicy(*options.RestartPolicy); err != nil { |
There was a problem hiding this comment.
we could warn and reset to the default restart policy here, not sure if this makes sense
There was a problem hiding this comment.
I think we should return an error if the user specified something wrong. Imagine it being used in a script or some kind of automation. Logs are usually only consulted when something went wrong, so we'd be hiding that.
There was a problem hiding this comment.
Yes returning an error is better, especially since warnings are not displayed on the remote client.
Handle custom restart policies of containers when generating the unit files; those should be set on the unit level and removed from ExecStart flags. Fixes: containers#11438 Signed-off-by: Valentin Rothberg <[email protected]>
|
ready to merge |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Handle custom restart policies of containers when generating the unit
files; those should be set on the unit level and removed from ExecStart
flags.
Fixes: #11438
Signed-off-by: Valentin Rothberg [email protected]